On Thu, 17 Oct 2024 16:17:02 GMT, Sandhya Viswanathan <sviswanat...@openjdk.org> wrote:
> > > Rather than adding more IR test functionality to this PR that requires > > > additional review my recommendation would be to follow up in another PR > > > or before hand rethink our approach. > > > > > > Agree, I am thinking of developing an automated IR validation > > infrastructure for all vector API operations, till then and for the sake of > > completeness of this patch we can let newly created IR based tests be part > > of this PR. > > @jatin-bhateja I agree with Paul, it would be good to remove the newly added > IR test changes from this PR to reduce the load on reviewers. You can always > send it as a separate PR. I have restricted the IR validation to just newly added UMin/UMax transformations. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20507#issuecomment-2420238761
