On Thu, 17 Oct 2024 15:41:58 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:

> > Rather than adding more IR test functionality to this PR that requires 
> > additional review my recommendation would be to follow up in another PR or 
> > before hand rethink our approach.
> 
> Agree, I am thinking of developing an automated IR validation infrastructure 
> for all vector API operations, till then and for the sake of completeness of 
> this patch we can let newly created IR based tests be part of this PR.

@jatin-bhateja I agree with Paul, it would be good to remove the newly added IR 
test changes from this PR to reduce the load on reviewers. You can always send 
it as a separate PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20507#issuecomment-2419973468

Reply via email to