On Mon, 7 Oct 2024 06:26:09 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review for this change which proposes to deprecate for >> removal the `jrunscript` tool? >> >> The `jrunscript` tool as documented in its specification >> https://docs.oracle.com/en/java/javase/23/docs/specs/man/jrunscript.html was >> an experimental and unsupported tool. Ever since the script engine >> implementations have been removed from the JDK, the default usage of this >> tool has been non-functional: >> >> >> $> jrunscript >> script engine for language js can not be found >> >> >> The tool itself could be launched by specifying a script engine >> implementation in the classpath, in which case it will use that script >> engine implementation. However, given that the JDK itself ships no such >> engines anymore and since there are no plans to continue support for this >> tool, the tool will now print a deprecation warning in preparation for its >> removal from a future release. >> >> No new tests have been added and existing tests in tier1, tier2 and tier3 >> continue to pass. I will draft a CSR (and a release note) shortly. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > update module-info of java.scripting to note about jrunscript tool > deprecation src/java.scripting/share/classes/module-info.java line 31: > 29: * <p> The <em>{@index jrunscript jrunscript tool}</em> included in the > JDK > 30: * implementation of this module, has been deprecated for removal since > 31: * JDK 24 and will be removed in a future release. "included" is past sentence. I think it would be better to keep the original text and just add new a sentence to say that the tool has been deprecated for removal in a future release. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21380#discussion_r1789596630
