On Mon, 7 Oct 2024 04:23:20 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review for this change which proposes to deprecate for > removal the `jrunscript` tool? > > The `jrunscript` tool as documented in its specification > https://docs.oracle.com/en/java/javase/23/docs/specs/man/jrunscript.html was > an experimental and unsupported tool. Ever since the script engine > implementations have been removed from the JDK, the default usage of this > tool has been non-functional: > > > $> jrunscript > script engine for language js can not be found > > > The tool itself could be launched by specifying a script engine > implementation in the classpath, in which case it will use that script engine > implementation. However, given that the JDK itself ships no such engines > anymore and since there are no plans to continue support for this tool, the > tool will now print a deprecation warning in preparation for its removal from > a future release. > > No new tests have been added and existing tests in tier1, tier2 and tier3 > continue to pass. I will draft a CSR (and a release note) shortly. Marked as reviewed by sundar (Reviewer). That documentation comment in module-info.java of java.scripting has to be updated for deprecation info of the tool (as you noted) Other changes look good to me ------------- PR Review: https://git.openjdk.org/jdk/pull/21380#pullrequestreview-2350841733 PR Comment: https://git.openjdk.org/jdk/pull/21380#issuecomment-2395891269
