On Wed, 25 Sep 2024 10:10:13 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/zip/ZipCoder.java line 69: >> >>> 67: * to the encoded string. >>> 68: */ >>> 69: EXACT_MATCH = 1, >> >> Would there be any (positive) performance implications of starting these at >> zero? > > It saves a byte since there are bytecode constants for `0`-`2` but not for > `3` :-) Fixed I misremembered: there are constant, single byte bytecodes up to `ICONST_5`. Alas, it's done, and no backsies. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21176#discussion_r1775004504
