On Wed, 25 Sep 2024 10:14:47 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1872:
>>
>>> 1870: // Compare the lookup name with the name encoded
>>> in the CEN
>>> 1871: switch (zc.compare(name, cen, noff, nlen,
>>> addSlash)) {
>>> 1872: case ZipCoder.EXACT_MATCH:
>>
>> This would perhaps read cleaner with a static import of the constants?
>
> No strong feeling about this, but I lean towards not using static imports
> unless there's repeated use.
No strong feelings here either, just thought it made the code easier on the
eye. I'll leave it to your preference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21176#discussion_r1774967673
