On Wed, 18 Sep 2024 12:23:48 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Sandhya Viswanathan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments > > I'm a bit confused by the name `shuffleWrapIndexes` and > `inline_vector_shuffle_wrap_indexes`. > > Are you **shuffling wrap-indexes**? I don't know what that would even mean. I > think you should name it `wrapShuffleIndexes`. Or is there any naming > convention in the VectorAPI that prevents this? Thanks a lot @eme64 for the review. I have implemented your review comment. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20634#issuecomment-2362253398
