On Mon, 16 Sep 2024 17:59:11 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update @link ->@linkplain
>
> src/java.base/share/classes/java/util/zip/ZipEntry.java line 44:
>
>> 42: * entry comment and {@linkplain #CENHDR CEN Header size}, must not
>> 43: * exceed 65,535 bytes. If it does, {@linkplain ZipOutputStream} will
>> 44: * throw a {@linkplain ZipException} when writing the ZIP file entry.
>
> This looks a little out of place in ZipEntry's class description, does
> ZOS.putNextEntry throw or is it just finish and close?
Short answer. finish() which calls writeCEN, will throw for the above.
As the entry comment, is only part of the CEN, I wanted to keep the encoding
in writeCEN as there is no reason to do it earlier.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21003#discussion_r1761646379
