On Mon, 16 Sep 2024 18:00:48 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update @link ->@linkplain
>
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 409:
>
>> 407: * A ZipException will be thrown if the combined length of the
>> entry name,
>> 408: * the extra field data, the entry comment and {@linkplain #CENHDR
>> CEN Header size},
>> 409: * exceeds 65,535 bytes.
>
> Is this missing text to say that close may write as part of closing?
ZipOutputStream::close() calls DeflaterOutputStream::close() will in turn will
call ZipOutputStream::finish()
I could remove the above and just leave the verbiage in
ZipOutputStream::finish(), I only added it to close as I didn't think it was
obvious that close resulted in a call to finish.
I do not have a strong preference or do you have an alterantive suggestion?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21003#discussion_r1761630685
