On Fri, 13 Sep 2024 06:32:54 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> This PR fixes a regression introduced by >> https://github.com/openjdk/jdk/pull/20848 > > src/java.base/share/classes/jdk/internal/foreign/SegmentBulkOperations.java > line 313: > >> 311: // The returned value is in the interval [0, 2^30] >> 312: static int powerOfPropertyOr(String name, int defaultPower) { >> 313: final String property = >> GetPropertyAction.privilegedGetProperty(PROPERTY_PATH + name); > > Hello Per, > `sun.security.action.GetIntegerAction.privilegedGetProperty(PROPERTY_PATH + > name, defaultPower)` could avoid the null checks and the try blocks here. Yes, the 2-arg GetIntegerAction.privilegedGetProperty would be better here, and it would retain the existing behavior for when the property value can't be parsed as a number. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20983#discussion_r1758277128
