On Mon, 2 Sep 2024 22:32:34 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> adjust indentation in X11Color.c > > src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 744: > >> 742: int rslt = pthread_attr_init(&attr); >> 743: if (rslt != 0) return; >> 744: pthread_create(&thr, &attr, SplashScreenThread, (void *) splash); > > You don't think it would be better to check the return code? This code is devoid of pretty much all error handling and logging, but I agree that a simple fprintf on error would be useful. Also doesn't a call like this trigger the warning about ignoring a function result, or have we disabled that one? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741354811
