On Mon, 2 Sep 2024 13:25:51 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> We get a couple of warnings as errors on AIX because of unused variables or >> functions , for example : >> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:665:10: >> error: unused variable 'exePath' [-Werror,-Wunused-variable] >> char exePath[PATH_MAX]; >> ^ >> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:668:9: >> error: unused variable 'ret' [-Werror,-Wunused-variable] >> int ret; >> ^ >> /priv/jenkins/client-home/workspace/openjdk-jdk-dev-aix_ppc64-opt/jdk/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c:664:10: >> error: unused variable 'fn' [-Werror,-Wunused-variable] >> char fn[32]; >> ^ >> >> This seems to be related to the recent make changes >> 8339156: Use more fine-granular clang unused warnings >> https://bugs.openjdk.org/browse/JDK-8339156 >> (we use clang too on AIX) > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > adjust indentation in X11Color.c src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 744: > 742: int rslt = pthread_attr_init(&attr); > 743: if (rslt != 0) return; > 744: pthread_create(&thr, &attr, SplashScreenThread, (void *) splash); You don't think it would be better to check the return code? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20812#discussion_r1741271285
