On Fri, 30 Aug 2024 11:40:45 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> src/hotspot/share/prims/whitebox.cpp line 2507: >> >>> 2505: WB_END >>> 2506: >>> 2507: // Physical cpus of the host machine (including containers), Linux >>> only. >> >> Isn't the comment a bit misleading ? From what I see , ` >> os::Linux::active_processor_count()` can use various mechanisms to get >> number of processor info, if it uses >> https://linux.die.net/man/2/sched_getaffinity it gives the 'set of CPUs on >> which it is eligible to run.' That might be different from what the host >> has. > > Yes. See #20768 for an attempt to unify it. I'll change the comment with the > update that I have for nested hierarchies. Thanks! I've changed the comment. >> test/hotspot/jtreg/containers/systemd/SystemdMemoryAwarenessTest.java line >> 58: >> >>> 56: SystemdRunOptions opts = >>> SystemdTestUtils.newOpts("HelloSystemd"); >>> 57: // 1 GB memory >>> 58: opts.memoryLimit("1000M"); >> >> Just wondering - is 1G here possible (the comment states 1 GB / 1024M) ? > > I probably shall fix the comment or change it to `1024M`. Either way it has > to match the assertion where we look for `1048576000` bytes in the output. This should be fixed now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19530#discussion_r1738770335 PR Review Comment: https://git.openjdk.org/jdk/pull/19530#discussion_r1738770983
