On Thu, 29 Aug 2024 15:22:02 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits since the last revision:
>>
>> - Add root check for SystemdMemoryAwarenessTest.java
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Add Whitebox check for host cpu
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Merge branch 'master' into jdk-8333446-systemd-slice-tests
>> - Fix comments
>> - 8333446: Add tests for hierarchical container support
>
> test/hotspot/jtreg/containers/systemd/SystemdMemoryAwarenessTest.java line 58:
>
>> 56: SystemdRunOptions opts =
>> SystemdTestUtils.newOpts("HelloSystemd");
>> 57: // 1 GB memory
>> 58: opts.memoryLimit("1000M");
>
> Just wondering - is 1G here possible (the comment states 1 GB / 1024M) ?
I probably shall fix the comment or change it to `1024M`. Either way it has to
match the assertion where we look for `1048576000` bytes in the output.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19530#discussion_r1736549823
