On Thu, 29 Aug 2024 05:24:18 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Merge branch 'anon' of github.com:coleenp/jdk into anon
>> - Fix copyright
>
> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdKlassQueue.cpp
> line 79:
>
>> 77:
>> 78: static bool can_compress_element(const Klass* klass) {
>> 79: return Metaspace::is_in_class_space(klass) &&
>
> Suggestion:
>
> return (Metaspace::is_in_class_space(klass) ||
> Metaspace::is_in_shared_metaspace(klass)) &&
Is this right? If UseCompressedClassPointers is off, then the shared metaspace
isn't in compressed space?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19157#discussion_r1736041738
