On Wed, 28 Aug 2024 05:57:14 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains four commits: >> >> - With JDK-8338929 we don't need is_in_class_space(). >> - Merge branch 'master' into anon >> - Incorporated a set of Thomas Stuefe's comments. Take out AbstractClass >> MetaspaceObj::Type. >> - 8338526: Don't store abstract and interface Klasses in class metaspace > > src/hotspot/share/oops/metadata.hpp line 2: > >> 1: /* >> 2: * Copyright (c) 2011, 2024, Oracle and/or its affiliates. All rights >> reserved. > > No more change in this file?
I removed the copyright. I tried to add an assert to CompresssedKlassPointers::encode_not_null but CDS calls this with ill-formed Klass* pointers so the tests crash. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19157#discussion_r1734914543
