On Mon, 29 Jul 2024 02:22:11 GMT, Chen Liang <li...@openjdk.org> wrote:
>> As discussed in offline meeting, the max stack and locals information are
>> part of the code attribute and not meaningful for buffered code elements.
>> Computation would be costly and these see no real usage during
>> transformations. Thus, the proposed solution is to move these APIs to be
>> CodeAttribute specific, as this is already how all these APIs' users are
>> using.
>>
>> Also removed useless `Writable` on buffered models, and fixed
>> `BufferedMethodBuilder::code` implementation.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo, and add tests
test/jdk/jdk/classfile/BuilderBlockTest.java line 353:
> 351: // not managed for now
> 352: @Test
> 353: void testAllocateLocalTransformingCodeAttribute() throws IOException
> {
Suggestion:
void testAllocateLocalTransformingCodeAttribute() throws IOException {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20338#discussion_r1694951218
