> As discussed in offline meeting, the max stack and locals information are > part of the code attribute and not meaningful for buffered code elements. > Computation would be costly and these see no real usage during > transformations. Thus, the proposed solution is to move these APIs to be > CodeAttribute specific, as this is already how all these APIs' users are > using. > > Also removed useless `Writable` on buffered models, and fixed > `BufferedMethodBuilder::code` implementation.
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://github.com/openjdk/jdk into fix/codemodel-maxes - Reuse local var management from buffered code builders - 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute ------------- Changes: - all: https://git.openjdk.org/jdk/pull/20338/files - new: https://git.openjdk.org/jdk/pull/20338/files/a1023837..6b93ad70 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=20338&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20338&range=00-01 Stats: 2948 lines in 126 files changed: 587 ins; 2154 del; 207 mod Patch: https://git.openjdk.org/jdk/pull/20338.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20338/head:pull/20338 PR: https://git.openjdk.org/jdk/pull/20338
