On Fri, 26 Jul 2024 20:45:43 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which is a simple doc only change to >> java.text.DecimalFormat. >> >> Mainly, the DecimalFormat constructors have wording that recommends using >> the NumberFormat factory methods for a standard formatting. This would be >> better tagged as an `@apiNote`. Minor wording updates included as well. >> >> A corresponding [CSR](https://bugs.openjdk.org/browse/JDK-8337286) has also >> been drafted. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > reflect review src/java.base/share/classes/java/text/DecimalFormat.java line 438: > 436: * NumberFormat#getNumberInstance(Locale)}. These factories will > return the most > 437: * appropriate subclass of NumberFormat for a given locale. > 438: * @see NumberFormat#getInstance() Suggestion: * @see NumberFormat#getInstance(Locale) and for other such links. I second @naotoj's remark. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20361#discussion_r1693605351
