On Fri, 26 Jul 2024 19:17:34 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which is a simple doc only change to > java.text.DecimalFormat. > > Mainly, the DecimalFormat constructors have wording that recommends using the > NumberFormat factory methods for a standard formatting. This would be better > tagged as an `@apiNote`. Minor wording updates included as well. > > A corresponding [CSR](https://bugs.openjdk.org/browse/JDK-8337286) has also > been drafted. src/java.base/share/classes/java/text/DecimalFormat.java line 441: > 439: * @see NumberFormat#getNumberInstance() > 440: * @see NumberFormat#getCurrencyInstance() > 441: * @see NumberFormat#getPercentInstance() The paragraph is for a "given" locale, probably factories that take Locale would be more appropriate than no-arg ones. (applies to other locations too) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20361#discussion_r1693536829