On Fri, 19 Jul 2024 20:55:03 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/StringConcatHelper.java line 371: >> >>> 369: return new String(s1); >>> 370: } >>> 371: byte coder = (byte) (s1.coder() | s2.coder()); >> >> Suggestion: >> >> int coder = s1.coder() | s2.coder(); > > Converting coder to int type requires processing when calling new > String(byte[], byte) You are right, I ignored that `coder` is reused again below. My bad! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20253#discussion_r1684964634
