On Fri, 19 Jul 2024 19:18:43 GMT, Shaojin Wen <d...@openjdk.org> wrote:
>> Currently simpleConcat is implemented using mix and prepend, but in this
>> simple scenario, it can be implemented in a simpler way and can improve
>> performance.
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> share newArray
src/java.base/share/classes/java/lang/StringConcatHelper.java line 371:
> 369: return new String(s1);
> 370: }
> 371: byte coder = (byte) (s1.coder() | s2.coder());
Suggestion:
int coder = s1.coder() | s2.coder();
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20253#discussion_r1684935704
