On Tue, 7 May 2024 18:39:40 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 28 commits: >> >> - Merge branch 'master' into JDK-8320396-verifier-extension >> - added references to jvms >> - Merge remote-tracking branch 'openjdk/master' into >> JDK-8320396-verifier-extension >> - work in progress >> - work in progress >> - work in progress >> - work in progress >> - work in progress >> - removed string templates from test >> - work in progress >> - ... and 18 more: https://git.openjdk.org/jdk/compare/ae82405f...3ebc780a > > src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java > line 97: > >> 95: check.accept(fre.owner()::asSymbol); >> 96: check.accept(fre::typeSymbol); >> 97: yield () -> >> verifyFieldName(fre.name().stringValue()); > > Nitpick, we should avoid capturing the check instance and just do something > like: > > case FieldRefEntry fre -> () -> { > fre.owner().asSymbol(); > fre.typeSymbol(); > verifyFieldName(fre.name().stringValue()); > }; The above code logs all errors individually. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1595196242
