On Thu, 21 Mar 2024 14:40:37 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only >> bytecode-level class verification. >> This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with >> additional class checks inspired by >> `hotspot/share/classfile/classFileParser.cpp`. >> >> Also new `VerifierSelfTest::testParserVerifier` has been added. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 26 commits: > > - Merge remote-tracking branch 'openjdk/master' into > JDK-8320396-verifier-extension > - work in progress > - work in progress > - work in progress > - work in progress > - work in progress > - removed string templates from test > - work in progress > - work in progress > - work in progress > - ... and 16 more: https://git.openjdk.org/jdk/compare/e41bc42d...54c4e9b9 src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java line 56: > 54: > 55: /** > 56: * @see <a > href="https://raw.githubusercontent.com/openjdk/jdk/master/src/hotspot/share/classfile/classFileParser.cpp";>hotspot/share/classfile/classFileParser.cpp</a> A reference to JVMS Ch4(?) would be appropriate here as that is what any checks should be compliant with. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1534955072
