On Fri, 5 Apr 2024 16:18:11 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - spaces
>> - nits and move file to aix directory
>
> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
> line 33:
>
>> 31: public class LoadAIXLibraryFromArchiveObject {
>> 32: public static void main(String[] args) throws Exception {
>> 33: String libraryName = "perfstat";
>
> I suggest to check if `/usr/lib/libperstat.a` is present and
> `/usr/lib/libperfstat.so` is not present; otherwise, the test should throw
> RuntimeException.
I understand. But isn't the presence of .so also a legit test case ? I mean
loadLibrary is not expected to fail if that happens. The failure is expected
when .so is not present and .a is also not present . Shouldn't we check for non
existence of both ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1554048115
