On Fri, 5 Apr 2024 17:41:36 GMT, Suchismith Roy <s...@openjdk.org> wrote:

>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - update tests
>  - update tests

test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
 line 37:

> 35:         File perfstatSharedObjectPath = new 
> File("/usr/lib/libperfstat.so");
> 36:         // If .a file is not present and .so file is present.
> 37:         if (!perfstatPath.exists() || !perfstatSharedObjectPath.exists())

This test does not compile.  Please run it before and after the fix to validate 
the fix.

Suggestion:

        if (!perfstatArchivePath.exists() || !perfstatSharedObjectPath.exists())

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1554046285

Reply via email to