On Thu, 22 Feb 2024 12:04:05 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Cleaner thread dequeue happens-before running cleaning action
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 491:
>
>> 489: * If this reference is not registered with a queue, or was already
>> enqueued
>> 490: * (by the garbage collector, or a previous call to {@code
>> enqueue}), this
>> 491: * method is <b><i>unnsuccessful</i></b> and returns false.
>
> Suggestion:
>
> * method is <b><i>unsuccessful</i></b> and returns false.
or, better yet, `fails`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1499141654
