On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >> A couple key things we want to be able to say are: >> - `Reference.reachabilityFence(x)` _happens-before_ reference processing >> occurs for 'x'. >> - `Cleaner.register()` _happens-before_ the Cleaner thread runs the >> registered cleaning action. >> >> This will bring Cleaner in line (or close) with the memory visibility >> guarantees made for finalizers in [JLS >> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5): >> _"There is a happens-before edge from the end of a constructor of an object >> to the start of a finalizer (§12.6) for that object."_ > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > Cleaner thread dequeue happens-before running cleaning action src/java.base/share/classes/java/lang/ref/Reference.java line 491: > 489: * If this reference is not registered with a queue, or was already > enqueued > 490: * (by the garbage collector, or a previous call to {@code > enqueue}), this > 491: * method is <b><i>unnsuccessful</i></b> and returns false. Suggestion: * method is <b><i>unsuccessful</i></b> and returns false. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16644#discussion_r1499140107
