On Thu, 25 Jan 2024 09:57:13 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Aggelos Biboudis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update year
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 148:
>
>> 146: * @throws NullPointerException if any argument is {@code null}
>> 147: * @throws IllegalArgumentException if any element in the labels
>> array is null, if the
>> 148: * invocation type is not a method type of first parameter of a
>> reference type,
>
> One thing we did often in the FFM API was to break up long `@throws` and
> split them into two or three `@throws` (javadoc allows the same exception to
> appear multiple times). Not saying you have to change this, just a possible
> suggestion (as I didn't know this!)
Indeed it looks better:
<img width="566" alt="Screenshot 2024-01-25 at 14 49 07"
src="https://github.com/openjdk/jdk/assets/765983/84e6ae34-1e6b-4d36-98de-78f101be2336";>
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466406565
