On Wed, 24 Jan 2024 23:50:51 GMT, Aggelos Biboudis <abimpou...@openjdk.org> wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and >> switch (Preview). >> >> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/ > > Aggelos Biboudis has updated the pull request incrementally with one > additional commit since the last revision: > > Update year src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 148: > 146: * @throws NullPointerException if any argument is {@code null} > 147: * @throws IllegalArgumentException if any element in the labels > array is null, if the > 148: * invocation type is not a method type of first parameter of a > reference type, One thing we did often in the FFM API was to break up long `@throws` and split them into two or three `@throws` (javadoc allows the same exception to appear multiple times). Not saying you have to change this, just a possible suggestion (as I didn't know this!) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1466119276
