On Wed, 24 Jan 2024 15:34:33 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Aggelos Biboudis has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Enhance Javadoc of ExactConversionsSupport (2) >> - Enhance Javadoc of ExactConversionsSupport > > src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 461: > >> 459: // Object o = ... >> 460: // o instanceof Wrapped(float) >> 461: cb.aload(0); > > probably just a matter of style so up to you, but I don't like the mixing of > low level code generation here with higher level logic. I would prefer to see > the code generation be extracted if possible to helper methods and or a > separate helper class. see my other comment above that I think supersedes this one ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465309941
