On Wed, 24 Jan 2024 15:26:54 GMT, Aggelos Biboudis <abimpou...@openjdk.org> wrote:
>> This is the proposed patch for Primitive types in patterns, instanceof, and >> switch (Preview). >> >> Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/ > > Aggelos Biboudis has updated the pull request incrementally with two > additional commits since the last revision: > > - Enhance Javadoc of ExactConversionsSupport (2) > - Enhance Javadoc of ExactConversionsSupport src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 461: > 459: // Object o = ... > 460: // o instanceof Wrapped(float) > 461: cb.aload(0); probably just a matter of style so up to you, but I don't like the mixing of low level code generation here with higher level logic. I would prefer to see the code generation be extracted if possible to helper methods and or a separate helper class. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15638#discussion_r1465102870
