On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace <d...@openjdk.org> wrote:
> Hi all, > > Please review this fix for jar tool not producing archive if there is a > missing file supplied. Fix is to throw an exception and exit processing when > a missing file is supplied. Current behaviour will recognise missing file as > an error but continue processing and not produce the archive. Updated > ClassPath test to verify jar is not created. > > Thanks, > Ryan. Thanks [jaikiran](https://github.com/jaikiran), the issue with the current functionality on the mainline is that the jar tool is still processing and creating the temp jar file, it just doesn't move it to the working directory where the tool was ran from because there was a missing file supplied and then deletes the temp jar. If you were to run this with many/larger files that causes the jartool to take more time it is more noticeable. Maybe it is better to follow the JDK 8 JarTool behaviour and still produce a jar file without the missing files as we are providing a warning to notify that there were missing files not included in the jar. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16423#issuecomment-1798286718
