On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace <d...@openjdk.org> wrote:
> Hi all, > > Please review this fix for jar tool not producing archive if there is a > missing file supplied. Fix is to throw an exception and exit processing when > a missing file is supplied. Current behaviour will recognise missing file as > an error but continue processing and not produce the archive. Updated > ClassPath test to verify jar is not created. > > Thanks, > Ryan. Hello Ryan, I ran a few experiments and I am unsure if we should be doing this change. Please consider this following scenario, when using the current implementation in mainline: echo "hello" > hello.txt jar -cf foo.jar missing.txt missing2.txt hello.txt ------------- PR Comment: https://git.openjdk.org/jdk/pull/16423#issuecomment-1797979185
