On Thu, 2 Nov 2023 14:38:06 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update JEP number in PreviewFeature > > src/java.base/share/classes/sun/launcher/LauncherHelper.java line 973: > >> 971: abort(null, "java.launcher.cls.error3", >> 972: mainMethod.getDeclaringClass().getName()); >> 973: } > > The simplification to LauncherHelper.validateMainClass looks okay but one > thing is a bit annoying is the side effect to set mainType. What would you > think about changing validateMainClass to return the Method for the main > class and have checkAndLoadMain set mainType after validateMainClass > succeeds, right not it gets set even if the validate fails. Agree. Will fetch flags from second call from JVM. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380276024
