On Thu, 2 Nov 2023 16:19:07 GMT, Jim Laskey <jlas...@openjdk.org> wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - Simplify main method search.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revised implicit class test
Added a few minor comments inline.
src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 33:
> 31: public class MainMethodFinder {
> 32: /**
> 33: * {@return true if method mets the requirements of a main method}
Nit/typo
Suggestion:
* {@return true if the method meets the requirements of a main method}
test/jdk/java/lang/Class/ImplicitClass/TestImplicitClass.java line 25:
> 23:
> 24: /*
> 25: * @test
As a mild preference, I would move this test into the javac/langtools tests. I
don't think it tests the reflection anymore, it rather tests that javac
desugars the code correctly.
-------------
PR Review: https://git.openjdk.org/jdk/pull/16461#pullrequestreview-1710864094
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380519226
PR Review Comment: https://git.openjdk.org/jdk/pull/16461#discussion_r1380544805
