On Wed, 1 Nov 2023 18:43:24 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Improve handling of layouts in NativeType.java >> - Check byte order of 4-byte aligned double. > > Thanks for testing! This sounds good. We need to handle the failing tests > separately as they are not immediately related to the up-/downcalls. > TestUpcallAsync is failing because of problems with > AttachCurrentThreadAsDaemon on AIX. The other ones because > libLoaderLookupInvoker.so seems to be broken on AIX. > @JornVernee: You had mentioned a javadoc update. Do we have to wait for > anything or can we ship it? > @suchismith1993: Please approve it when you think it's good to go. @TheRealMDoerr This is good to go. We will clarify the javadoc separately (https://bugs.openjdk.org/browse/JDK-8319316) ------------- PR Comment: https://git.openjdk.org/jdk/pull/16179#issuecomment-1790677435
