On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition, >> double values have only 4 Byte alignment within structures. This PR is based >> on JDK22 version of the FFI. > > Martin Doerr has updated the pull request incrementally with two additional > commits since the last revision: > > - Improve handling of layouts in NativeType.java > - Check byte order of 4-byte aligned double. Thanks for testing! This sounds good. We need to handle the failing tests separately as they are not immediately related to the up-/downcalls. TestUpcallAsync is failing because of problems with AttachCurrentThreadAsDaemon on AIX. The other ones because libLoaderLookupInvoker.so seems to be broken on AIX. @JornVernee: You had mentioned a javadoc update. Do we have to wait for anything or can we ship it? @suchismith1993: Please approve it when you think it's good to go. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16179#issuecomment-1789469814
