On Wed, 11 Oct 2023 13:53:58 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> This PR refactors the SSLSocketParametersTest by removing >> redundant/unnecessary classes and cleans up the logic around expected >> exceptions. > > Matthew Donovan has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'master' into socket-params > - Merge branch 'master' into socket-params > - added javadocs to new methods > - 8303525: Refactor/cleanup > open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java the test method testServerFactory could be viewed as a misnomer, so refactor rename testSslServerSocketFactory would seem to be more appropriate, while the serverFactory parameter name to testRmiCommunication could likewise be renamed to sslServerSocketFactory (or at least serverSocketFactory). ------------- PR Comment: https://git.openjdk.org/jdk/pull/14932#issuecomment-1764338318
