On Wed, 11 Oct 2023 13:53:58 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> This PR refactors the SSLSocketParametersTest by removing
>> redundant/unnecessary classes and cleans up the logic around expected
>> exceptions.
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains four additional
> commits since the last revision:
>
> - Merge branch 'master' into socket-params
> - Merge branch 'master' into socket-params
> - added javadocs to new methods
> - 8303525: Refactor/cleanup
> open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java
test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java line 77:
> 75:
> 76: public void testRmiCommunication(RMIServerSocketFactory
> serverFactory) throws Exception {
> 77: Hello stub = (Hello)UnicastRemoteObject.exportObject(new
> HelloImpl(),
by not retaining an explicit reference to the test rmi server, you are exposing
it to potentially being GCed during the test execution and potemntially prior
to client invocation... this might sound fanciful but this has been observed
in a few scenarios due to the GC changes ... althought it doesn't seem to have
been an issue, the structure of the test appears to be inherently racy, with
the potential for the client invocation to get ahead of the client with the rmi
server launching bacground threads.
Any caution on not retaining a sever reference and GC interference.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14932#discussion_r1360500322
