On Fri, 6 Oct 2023 17:50:56 GMT, Justin Lu <j...@openjdk.org> wrote: >> Please review this PR which refactors the ChoiceFormat tests to use JUnit. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Review: separate into two tests
Good point dividing the test for granularity. Looks good test/jdk/java/text/Format/ChoiceFormat/Bug8001209.java line 69: > 67: > 68: /* > 69: * Ensure that mutating he arrays returned by getChoices and > getLimits does Nit: typo "he" ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16065#pullrequestreview-1662596243 PR Review Comment: https://git.openjdk.org/jdk/pull/16065#discussion_r1349187144
