On Fri, 6 Oct 2023 16:54:03 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review: separate into two tests > > test/jdk/java/text/Format/ChoiceFormat/Bug8001209.java line 78: > >> 76: "Mutating array returned from getter changed internals >> of ChoiceFormat"); >> 77: >> 78: // Modify the array passed to setFormats() -> dayOfWeekNames > > I think we should keep the `err` variable, and not throw an exception (and > end the test) here. Otherwise, the test after this will not run. You're right, I should have actually split this larger test into two separate tests (one for the getter / one for the setter), then there would be no need for `err`. I have updated the PR with the change I mentioned. Thank you for reviewing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16065#discussion_r1349144926
