On Fri, 6 Oct 2023 02:22:52 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this change which proposes to implement the >> enhancement request noted in https://bugs.openjdk.org/browse/JDK-8317634? >> >> The change in this commit introduces a new `exclude-modules` argument to the >> `dedup-legal-notices` jlink plugin. This optional argument takes a comma >> separated values of module names. These module names are then excluded from >> the de-duplication of license notice files during image generation. >> >> (Edited to add some context) The motivation for this change is discussed >> here https://github.com/openjdk/jdk/pull/13686#issuecomment-1747301865 >> >> Two new test methods have been added to the existing `LegalFilePluginTest` >> jtreg test case to verify this implementation. Existing tests in >> `test/jdk/tools/jlink` continue to pass. tier testing is currently in >> progress. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > minor changes to the text in plugin.properties for the new argument, to > render better on command line Hello Alan, the proposal to introduce this enhancement was based on the discussion in the other PR here https://github.com/openjdk/jdk/pull/13686#issuecomment-1747301865. Mandy suggested that we could pursue this approach to allow certain modules (like jdk.javadoc) to disable de-duplication so that they can then (at runtime) have the actual legal notice files available to them without having to resort to brittle tricks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/16066#issuecomment-1750005350
