On Fri, 7 Jul 2023 07:55:03 GMT, sid8606 <d...@openjdk.org> wrote:
> Implementation of "Foreign Function & Memory API" for s390x.
Will run test, maybe you want to adopt these changes. That's it for now.
src/hotspot/cpu/s390/downcallLinker_s390.cpp line 2:
> 1: /*
> 2: * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
Please add the header-year back
src/hotspot/cpu/s390/downcallLinker_s390.cpp line 78:
> 76: _frame_complete(0),
> 77: _frame_size_slots(0),
> 78: _oop_maps(NULL) {
replace NULL with `nullptr`
src/hotspot/cpu/s390/downcallLinker_s390.cpp line 105:
> 103: bool needs_return_buffer,
> 104: int captured_state_mask,
> 105: bool needs_transition) {
maybe indent it back (?)
src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 2:
> 1: /*
> 2: * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
Please add the header-year back
src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 46:
> 44: bool ABIDescriptor::is_volatile_reg(FloatRegister reg) const {
> 45: return _float_argument_registers.contains(reg)
> 46: || _float_additional_volatile_registers.contains(reg);
maybe alignment needed (?)
src/hotspot/cpu/s390/frame_s390.cpp line 231:
> 229: UpcallStub* blob = _cb->as_upcall_stub();
> 230: JavaFrameAnchor* jfa = blob->jfa_for_frame(*this);
> 231: return jfa->last_Java_sp() == NULL;
Replace NULL with nullptr
src/hotspot/cpu/s390/frame_s390.cpp line 235:
> 233:
> 234: frame frame::sender_for_upcall_stub_frame(RegisterMap* map) const {
> 235: assert(map != NULL, "map must be set");
use nullptr
src/java.base/share/classes/jdk/internal/foreign/abi/s390/S390Architecture.java
line 3:
> 1: /*
> 2: * Copyright (c) 2020, 2023, Oracle and/or its affiliates. All rights
> reserved.
> 3: * Copyright (c) 2023 SAP SE. All rights reserved.
Add IBM's Copyrights ;-)
` Copyright (c) 2023, IBM Corp.`
src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger.java
line 3:
> 1: /*
> 2: * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights
> reserved.
> 3: * Copyright (c) 2023 SAP SE. All rights reserved.
Add IBM's copyright
src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390Linker.java
line 3:
> 1: /*
> 2: * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights
> reserved.
> 3: * Copyright (c) 2023 SAP SE. All rights reserved.
Add IBM's copyright
src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/TypeClass.java
line 3:
> 1: /*
> 2: * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights
> reserved.
> 3: * Copyright (c) 2023 SAP SE. All rights reserved.
Add IBM's copyright
-------------
Changes requested by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/14801#pullrequestreview-1518282531
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255434276
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255447838
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255473422
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255435187
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255440455
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255449488
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255449998
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255464266
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255465193
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255465767
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255467623
