On Mon, 3 Jul 2023 17:55:51 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Review: Remove Bug8025703.java and add to LSRT.java >> - Review: Clarify comments in ISO639.java > > test/jdk/java/util/Locale/Bug8025703.java line 48: > >> 46: * language priority list by matching the correct tag(s). This test >> 47: * was originally created to verify an older update to the LSR data >> file, >> 48: * and the test may be deprecated by LanguageSubtagRegistryTest.java > > If that's the case, can we update `LanguageSubtagRegistryTest.java` to cover > these older updates and remove this test? Yes, merged the tags from `Bug8025703.java` into `LanguageSubtagRegistryTest.java` and removed `Bug8025703.java`. > test/jdk/java/util/Locale/ISO639.java line 299: > >> 297: >> 298: // CODES generated from >> https://www.loc.gov/standards/iso639-2/ISO-639-2_utf-8.txt >> 299: // on March 9th, 2023. > > Should be `expectedISO639Codes` instead of `CODES`, and this comment would be > better placed on top of `expectedISO639Codes` method Adjusted ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14721#discussion_r1254834468 PR Review Comment: https://git.openjdk.org/jdk/pull/14721#discussion_r1254834584
