On Fri, 30 Jun 2023 07:52:36 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which refactors additional tests in Locale to use JUnit. > > If a test was named bugNNNNNNN.java, it was renamed to something more > descriptive. > > Below is a list of all the changes > > - Refactor and Rename Bug4175998Test.java as ISO639.java > - Refactor and Rename Bug8001562.java as JDK7LocaleServiceDiffs.java > - Refactor and Rename Bug8008577.java as ExpectedAdapterTypes.java > - Refactor Bug8025703.java > - Refactor and Rename Bug8026766.java as LRToString.java > - Refactor and Rename Bug8071929.java as ISO3166.java > - Refactor and Rename Bug8032842.java to PreserveTagCase.java test/jdk/java/util/Locale/Bug8025703.java line 48: > 46: * language priority list by matching the correct tag(s). This test > 47: * was originally created to verify an older update to the LSR data > file, > 48: * and the test may be deprecated by LanguageSubtagRegistryTest.java If that's the case, can we update `LanguageSubtagRegistryTest.java` to cover these older updates and remove this test? test/jdk/java/util/Locale/ISO639.java line 299: > 297: > 298: // CODES generated from > https://www.loc.gov/standards/iso639-2/ISO-639-2_utf-8.txt > 299: // on March 9th, 2023. Should be `expectedISO639Codes` instead of `CODES`, and this comment would be better placed on top of `expectedISO639Codes` method ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14721#discussion_r1251159222 PR Review Comment: https://git.openjdk.org/jdk/pull/14721#discussion_r1251155431
