On Tue, 27 Jun 2023 14:20:20 GMT, Chen Liang <li...@openjdk.org> wrote:
>> This would encourage Classfile API users to use the descriptors as >> constants, which can improve performance by avoiding repeated validation and >> reusing cached descriptor strings for MethodTypeDesc. This patch updates >> usages in the main codebase and benchmarks; tests are left untouched. >> >> See >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000378.html > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into fix/cd-usage > - Merge branch 'master' into fix/cd-usage > - Fix build > - 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final > fields This code replacing repeated symbols instantiation with static fields looks good. However the patch also contains significant refactoring of jdk.jlink SystemModulesPlugin and significant refactoring of the JMH benchmarks Write class. I suggest to split this PR or link additional issues to it. There is missing description of the problems so the proposed solution cannot be reviewed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14640#issuecomment-1611284383
