On Tue, 27 Jun 2023 14:20:20 GMT, Chen Liang <li...@openjdk.org> wrote:
>> This would encourage Classfile API users to use the descriptors as >> constants, which can improve performance by avoiding repeated validation and >> reusing cached descriptor strings for MethodTypeDesc. This patch updates >> usages in the main codebase and benchmarks; tests are left untouched. >> >> See >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000378.html > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into fix/cd-usage > - Merge branch 'master' into fix/cd-usage > - Fix build > - 8310848: Convert ClassDesc and MethodTypeDesc to be stored in static final > fields @asotona Can you review this patch that migrates MethodTypeDesc creation to static final field access whenever possible? This allows to reuse cached descriptor strings and avoid revalidation. In addition, I dropped the jdkTreePrimitive benchmark for jdk.classfile.Write, which is identical to jdkTree as far as I see. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14640#issuecomment-1610809614
