On Thu, 22 Jun 2023 18:30:55 GMT, Lance Andersen <[email protected]> wrote:
>> test/jdk/java/util/Locale/LocaleConstructors.java line 51:
>>
>>> 49: public void langTest() {
>>> 50: Locale aLocale = Locale.of(LANG);
>>> 51: Locale otherLocale = new Locale(LANG);
>>
>> Is there a preference on testing code that is marked as `@deprecated` in the
>> JDK? This test originally validated the parameters of the deprecated Locale
>> constructor but was changed in 2022 with the Locale.of() method. However,
>> the test was originally meant to test the constructor so I re-inserted it
>> here.
>
> If the functionality still exists we should keep the existing test(s)
Got it, will leave it in then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14609#discussion_r1238912827
