On Thu, 22 Jun 2023 01:08:30 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR as apart of > [JDK-8307843](https://bugs.openjdk.org/browse/JDK-8307843) which refactors > some tests in Locale to use JUnit. Other cleanup and small changes are > included as well. More refactoring in Locale tests will be done in separate > PRs. > > If the test had a bugNNNNN.java name, it was also renamed to something more > [descriptive](https://openjdk.org/jtreg/faq.html#how-should-i-name-a-test). > > Below is a list of all the changes, > > - Refactor Bug4316602.java as LocaleConstructors.java > - Refactor Bug4210525.java as CaseCheckVariant.java > - Refactor bug6277243.java as RootLocale.java > - Refactor bug6312358.java as GetInstanceCheck.java > - Refactor Bug8154797.java as CompareProviderFormats.java > - Refactor Bug8004240.java as GetAdapterPreference.java > - Refactor bug4122700.java into AvailableLocalesTest.java (and combined with > StreamAvailableLocales.java) test/jdk/java/util/Locale/LocaleConstructors.java line 56: > 54: } > 55: > 56: @Test Minor, but please consider a simple comment describing the tests intent. Just makes it easier for future developers... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14609#discussion_r1238897495
